Increase ruff coverage (#23644)
CI / AMD64 Build (push) Waiting to run
CI / ARM Build (push) Waiting to run
CI / AMD64 Extra Build (push) Blocked by required conditions
CI / ARM Extra Build (push) Blocked by required conditions
CI / Synaptics Build (push) Blocked by required conditions
CI / Assemble and push default build (push) Blocked by required conditions
CI / Jetson Jetpack 6 (push) Waiting to run

* Pin ruff

* Add python upgrade fixes

This enables python upgrade checks in ruff to look for deprecated types and patterns. This namely fixes:
- usage of deprecated `Typing` which is now built in
- some specific exceptions which are caught and have new aliases

Some specific UP checks were also ignored as they are stylistic / unimportant and likely to cause bugs

* Remove async blocking calls

Use asyncio.to_thread on two remaining blocking calls to fix hanging event thread loop. Enable this specific rule to block it in the future.

* Use proper logging mechanism

* Correctly format logs

* Raise with context

When raising an exception include the from context to improve debugging

* Cleanup
This commit is contained in:
Nicolas Mowen
2026-07-06 12:28:02 -05:00
committed by GitHub
parent 455b8687e8
commit 4ee12e6237
169 changed files with 1053 additions and 1150 deletions
+3 -3
View File
@@ -84,7 +84,7 @@ def read_training_metadata(model_name: str) -> dict[str, any] | None:
return None
try:
with open(metadata_path, "r") as f:
with open(metadata_path) as f:
metadata = json.load(f)
return metadata
except Exception as e:
@@ -294,7 +294,7 @@ class ClassificationTrainingProcess(FrigateProcess):
return True
except Exception as e:
logger.error(f"Training failed for {self.model_name}: {e}", exc_info=True)
logger.exception(f"Training failed for {self.model_name}: {e}")
return False
@@ -732,7 +732,7 @@ def collect_object_classification_examples(
# Step 1: Query events for the specified label and cameras
events = list(
Event.select().where((Event.label == label)).order_by(Event.start_time.asc())
Event.select().where(Event.label == label).order_by(Event.start_time.asc())
)
if not events: