Increase ruff coverage (#23644)
CI / AMD64 Build (push) Waiting to run
CI / ARM Build (push) Waiting to run
CI / AMD64 Extra Build (push) Blocked by required conditions
CI / ARM Extra Build (push) Blocked by required conditions
CI / Synaptics Build (push) Blocked by required conditions
CI / Assemble and push default build (push) Blocked by required conditions
CI / Jetson Jetpack 6 (push) Waiting to run

* Pin ruff

* Add python upgrade fixes

This enables python upgrade checks in ruff to look for deprecated types and patterns. This namely fixes:
- usage of deprecated `Typing` which is now built in
- some specific exceptions which are caught and have new aliases

Some specific UP checks were also ignored as they are stylistic / unimportant and likely to cause bugs

* Remove async blocking calls

Use asyncio.to_thread on two remaining blocking calls to fix hanging event thread loop. Enable this specific rule to block it in the future.

* Use proper logging mechanism

* Correctly format logs

* Raise with context

When raising an exception include the from context to improve debugging

* Cleanup
This commit is contained in:
Nicolas Mowen
2026-07-06 12:28:02 -05:00
committed by GitHub
parent 455b8687e8
commit 4ee12e6237
169 changed files with 1053 additions and 1150 deletions
+2 -1
View File
@@ -1,7 +1,8 @@
import logging
import random
import string
from typing import Any, Sequence, cast
from collections.abc import Sequence
from typing import Any, cast
import cv2
import numpy as np
+3 -3
View File
@@ -5,7 +5,7 @@ import math
import os
from collections import defaultdict
from statistics import median
from typing import Any, Optional, cast
from typing import Any, cast
import cv2
import numpy as np
@@ -81,7 +81,7 @@ class TrackedObject:
self.previous = self.to_dict()
@property
def max_severity(self) -> Optional[str]:
def max_severity(self) -> str | None:
review_config = self.camera_config.review
if (
@@ -590,7 +590,7 @@ class TrackedObjectAttribute:
"box": self.box,
}
def find_best_object(self, objects: list[dict[str, Any]]) -> Optional[str]:
def find_best_object(self, objects: list[dict[str, Any]]) -> str | None:
"""Find the best attribute for each object and return its ID."""
best_object_area: float | None = None
best_object_id: str | None = None