Increase ruff coverage (#23644)
CI / AMD64 Build (push) Waiting to run
CI / ARM Build (push) Waiting to run
CI / AMD64 Extra Build (push) Blocked by required conditions
CI / ARM Extra Build (push) Blocked by required conditions
CI / Synaptics Build (push) Blocked by required conditions
CI / Assemble and push default build (push) Blocked by required conditions
CI / Jetson Jetpack 6 (push) Waiting to run

* Pin ruff

* Add python upgrade fixes

This enables python upgrade checks in ruff to look for deprecated types and patterns. This namely fixes:
- usage of deprecated `Typing` which is now built in
- some specific exceptions which are caught and have new aliases

Some specific UP checks were also ignored as they are stylistic / unimportant and likely to cause bugs

* Remove async blocking calls

Use asyncio.to_thread on two remaining blocking calls to fix hanging event thread loop. Enable this specific rule to block it in the future.

* Use proper logging mechanism

* Correctly format logs

* Raise with context

When raising an exception include the from context to improve debugging

* Cleanup
This commit is contained in:
Nicolas Mowen
2026-07-06 12:28:02 -05:00
committed by GitHub
parent 455b8687e8
commit 4ee12e6237
169 changed files with 1053 additions and 1150 deletions
+11 -10
View File
@@ -6,7 +6,8 @@ import logging
import os
import re
import time
from typing import Any, AsyncGenerator, Callable, Optional
from collections.abc import AsyncGenerator, Callable
from typing import Any
import numpy as np
from pydantic import ValidationError
@@ -235,7 +236,7 @@ class GenAIClient:
camera_config: CameraConfig,
thumbnails: list[bytes],
event: Event,
) -> Optional[str]:
) -> str | None:
"""Generate a description for the frame."""
try:
prompt = build_object_description_prompt(camera_config, event)
@@ -254,9 +255,9 @@ class GenAIClient:
self,
prompt: str,
images: list[bytes],
response_format: Optional[dict] = None,
response_format: dict | None = None,
enable_thinking: bool = False,
) -> Optional[str]:
) -> str | None:
"""Submit a request to the provider.
``enable_thinking`` is honored only by providers that report
@@ -321,9 +322,9 @@ class GenAIClient:
def chat_with_tools(
self,
messages: list[dict[str, Any]],
tools: Optional[list[dict[str, Any]]] = None,
tool_choice: Optional[str] = "auto",
enable_thinking: Optional[bool] = None,
tools: list[dict[str, Any]] | None = None,
tool_choice: str | None = "auto",
enable_thinking: bool | None = None,
) -> dict[str, Any]:
"""
Send chat messages to LLM with optional tool definitions.
@@ -395,9 +396,9 @@ class GenAIClient:
async def chat_with_tools_stream(
self,
messages: list[dict[str, Any]],
tools: Optional[list[dict[str, Any]]] = None,
tool_choice: Optional[str] = "auto",
enable_thinking: Optional[bool] = None,
tools: list[dict[str, Any]] | None = None,
tool_choice: str | None = "auto",
enable_thinking: bool | None = None,
) -> AsyncGenerator[tuple[str, Any], None]:
"""Streaming counterpart to `chat_with_tools`.