Increase ruff coverage (#23644)

* Pin ruff

* Add python upgrade fixes

This enables python upgrade checks in ruff to look for deprecated types and patterns. This namely fixes:
- usage of deprecated `Typing` which is now built in
- some specific exceptions which are caught and have new aliases

Some specific UP checks were also ignored as they are stylistic / unimportant and likely to cause bugs

* Remove async blocking calls

Use asyncio.to_thread on two remaining blocking calls to fix hanging event thread loop. Enable this specific rule to block it in the future.

* Use proper logging mechanism

* Correctly format logs

* Raise with context

When raising an exception include the from context to improve debugging

* Cleanup

frigate/api/defs/query/app_query_parameters.py

@@ -1,12 +1,10 @@
-from typing import Optional
-
 from pydantic import BaseModel
 
 
 class AppTimelineHourlyQueryParameters(BaseModel):
-    cameras: Optional[str] = "all"
-    labels: Optional[str] = "all"
-    after: Optional[float] = None
-    before: Optional[float] = None
-    limit: Optional[int] = 200
-    timezone: Optional[str] = "utc"
+    cameras: str | None = "all"
+    labels: str | None = "all"
+    after: float | None = None
+    before: float | None = None
+    limit: int | None = 200
+    timezone: str | None = "utc"

frigate/api/defs/query/events_query_parameters.py

@@ -1,28 +1,26 @@
-from typing import Optional
-
 from pydantic import BaseModel, Field
 
 DEFAULT_TIME_RANGE = "00:00,24:00"
 
 
 class EventsQueryParams(BaseModel):
-    camera: Optional[str] = "all"
-    cameras: Optional[str] = "all"
-    label: Optional[str] = "all"
-    labels: Optional[str] = "all"
-    sub_label: Optional[str] = "all"
-    sub_labels: Optional[str] = "all"
-    attributes: Optional[str] = "all"
-    zone: Optional[str] = "all"
-    zones: Optional[str] = "all"
-    limit: Optional[int] = 100
-    after: Optional[float] = None
-    before: Optional[float] = None
-    time_range: Optional[str] = DEFAULT_TIME_RANGE
-    has_clip: Optional[int] = None
-    has_snapshot: Optional[int] = None
-    in_progress: Optional[int] = None
-    include_thumbnails: Optional[int] = Field(
+    camera: str | None = "all"
+    cameras: str | None = "all"
+    label: str | None = "all"
+    labels: str | None = "all"
+    sub_label: str | None = "all"
+    sub_labels: str | None = "all"
+    attributes: str | None = "all"
+    zone: str | None = "all"
+    zones: str | None = "all"
+    limit: int | None = 100
+    after: float | None = None
+    before: float | None = None
+    time_range: str | None = DEFAULT_TIME_RANGE
+    has_clip: int | None = None
+    has_snapshot: int | None = None
+    in_progress: int | None = None
+    include_thumbnails: int | None = Field(
         1,
         description=(
             "Deprecated. Thumbnail data is no longer included in the response. "
@@ -30,25 +28,25 @@ class EventsQueryParams(BaseModel):
         ),
         deprecated=True,
     )
-    favorites: Optional[int] = None
-    min_score: Optional[float] = None
-    max_score: Optional[float] = None
-    min_speed: Optional[float] = None
-    max_speed: Optional[float] = None
-    recognized_license_plate: Optional[str] = "all"
-    is_submitted: Optional[int] = None
-    min_length: Optional[float] = None
-    max_length: Optional[float] = None
-    event_id: Optional[str] = None
-    sort: Optional[str] = None
-    timezone: Optional[str] = "utc"
+    favorites: int | None = None
+    min_score: float | None = None
+    max_score: float | None = None
+    min_speed: float | None = None
+    max_speed: float | None = None
+    recognized_license_plate: str | None = "all"
+    is_submitted: int | None = None
+    min_length: float | None = None
+    max_length: float | None = None
+    event_id: str | None = None
+    sort: str | None = None
+    timezone: str | None = "utc"
 
 
 class EventsSearchQueryParams(BaseModel):
-    query: Optional[str] = None
-    event_id: Optional[str] = None
-    search_type: Optional[str] = "thumbnail"
-    include_thumbnails: Optional[int] = Field(
+    query: str | None = None
+    event_id: str | None = None
+    search_type: str | None = "thumbnail"
+    include_thumbnails: int | None = Field(
         1,
         description=(
             "Deprecated. Thumbnail data is no longer included in the response. "
@@ -56,28 +54,28 @@ class EventsSearchQueryParams(BaseModel):
         ),
         deprecated=True,
     )
-    limit: Optional[int] = 50
-    cameras: Optional[str] = "all"
-    labels: Optional[str] = "all"
-    sub_labels: Optional[str] = "all"
-    attributes: Optional[str] = "all"
-    zones: Optional[str] = "all"
-    after: Optional[float] = None
-    before: Optional[float] = None
-    time_range: Optional[str] = DEFAULT_TIME_RANGE
-    has_clip: Optional[bool] = None
-    has_snapshot: Optional[bool] = None
-    is_submitted: Optional[bool] = None
-    timezone: Optional[str] = "utc"
-    min_score: Optional[float] = None
-    max_score: Optional[float] = None
-    min_speed: Optional[float] = None
-    max_speed: Optional[float] = None
-    recognized_license_plate: Optional[str] = "all"
-    sort: Optional[str] = None
+    limit: int | None = 50
+    cameras: str | None = "all"
+    labels: str | None = "all"
+    sub_labels: str | None = "all"
+    attributes: str | None = "all"
+    zones: str | None = "all"
+    after: float | None = None
+    before: float | None = None
+    time_range: str | None = DEFAULT_TIME_RANGE
+    has_clip: bool | None = None
+    has_snapshot: bool | None = None
+    is_submitted: bool | None = None
+    timezone: str | None = "utc"
+    min_score: float | None = None
+    max_score: float | None = None
+    min_speed: float | None = None
+    max_speed: float | None = None
+    recognized_license_plate: str | None = "all"
+    sort: str | None = None
 
 
 class EventsSummaryQueryParams(BaseModel):
-    timezone: Optional[str] = "utc"
-    has_clip: Optional[int] = None
-    has_snapshot: Optional[int] = None
+    timezone: str | None = "utc"
+    has_clip: int | None = None
+    has_snapshot: int | None = None

frigate/api/defs/query/media_query_parameters.py

@@ -1,5 +1,4 @@
 from enum import Enum
-from typing import Optional
 
 from pydantic import BaseModel
 
@@ -17,33 +16,33 @@ class Extension(str, Enum):
 
 
 class MediaLatestFrameQueryParams(BaseModel):
-    bbox: Optional[int] = None
-    timestamp: Optional[int] = None
-    zones: Optional[int] = None
-    mask: Optional[int] = None
-    motion: Optional[int] = None
-    paths: Optional[int] = None
-    regions: Optional[int] = None
-    quality: Optional[int] = 70
-    height: Optional[int] = None
-    store: Optional[int] = None
+    bbox: int | None = None
+    timestamp: int | None = None
+    zones: int | None = None
+    mask: int | None = None
+    motion: int | None = None
+    paths: int | None = None
+    regions: int | None = None
+    quality: int | None = 70
+    height: int | None = None
+    store: int | None = None
 
 
 class MediaEventsSnapshotQueryParams(BaseModel):
-    download: Optional[bool] = False
-    timestamp: Optional[int] = None
-    bbox: Optional[int] = None
-    crop: Optional[int] = None
-    height: Optional[int] = None
-    quality: Optional[int] = None
+    download: bool | None = False
+    timestamp: int | None = None
+    bbox: int | None = None
+    crop: int | None = None
+    height: int | None = None
+    quality: int | None = None
 
 
 class MediaMjpegFeedQueryParams(BaseModel):
     fps: int = 3
     height: int = 360
-    bbox: Optional[int] = None
-    timestamp: Optional[int] = None
-    zones: Optional[int] = None
-    mask: Optional[int] = None
-    motion: Optional[int] = None
-    regions: Optional[int] = None
+    bbox: int | None = None
+    timestamp: int | None = None
+    zones: int | None = None
+    mask: int | None = None
+    motion: int | None = None
+    regions: int | None = None

frigate/api/defs/query/recordings_query_parameters.py

@@ -1,21 +1,19 @@
-from typing import Optional, Union
-
 from pydantic import BaseModel
 from pydantic.json_schema import SkipJsonSchema
 
 
 class MediaRecordingsSummaryQueryParams(BaseModel):
     timezone: str = "utc"
-    cameras: Optional[str] = "all"
+    cameras: str | None = "all"
 
 
 class MediaRecordingsAvailabilityQueryParams(BaseModel):
     cameras: str = "all"
-    before: Union[float, SkipJsonSchema[None]] = None
-    after: Union[float, SkipJsonSchema[None]] = None
+    before: float | SkipJsonSchema[None] = None
+    after: float | SkipJsonSchema[None] = None
     scale: int = 30
 
 
 class RecordingsDeleteQueryParams(BaseModel):
-    keep: Optional[str] = None
-    cameras: Optional[str] = "all"
+    keep: str | None = None
+    cameras: str | None = "all"

frigate/api/defs/query/regenerate_query_parameters.py

@@ -1,13 +1,11 @@
-from typing import Optional
-
 from pydantic import BaseModel, Field
 
 from frigate.events.types import RegenerateDescriptionEnum
 
 
 class RegenerateQueryParameters(BaseModel):
-    source: Optional[RegenerateDescriptionEnum] = RegenerateDescriptionEnum.thumbnails
-    force: Optional[bool] = Field(
+    source: RegenerateDescriptionEnum | None = RegenerateDescriptionEnum.thumbnails
+    force: bool | None = Field(
         default=False,
         description="Force (re)generating the description even if GenAI is disabled for this camera.",
     )

frigate/api/defs/query/review_query_parameters.py

@@ -1,5 +1,3 @@
-from typing import Union
-
 from pydantic import BaseModel
 from pydantic.json_schema import SkipJsonSchema
 
@@ -10,11 +8,11 @@ class ReviewQueryParams(BaseModel):
     cameras: str = "all"
     labels: str = "all"
     zones: str = "all"
-    reviewed: Union[int, SkipJsonSchema[None]] = None
-    limit: Union[int, SkipJsonSchema[None]] = None
-    severity: Union[SeverityEnum, SkipJsonSchema[None]] = None
-    before: Union[float, SkipJsonSchema[None]] = None
-    after: Union[float, SkipJsonSchema[None]] = None
+    reviewed: int | SkipJsonSchema[None] = None
+    limit: int | SkipJsonSchema[None] = None
+    severity: SeverityEnum | SkipJsonSchema[None] = None
+    before: float | SkipJsonSchema[None] = None
+    after: float | SkipJsonSchema[None] = None
 
 
 class ReviewSummaryQueryParams(BaseModel):
@@ -26,6 +24,6 @@ class ReviewSummaryQueryParams(BaseModel):
 
 class ReviewActivityMotionQueryParams(BaseModel):
     cameras: str = "all"
-    before: Union[float, SkipJsonSchema[None]] = None
-    after: Union[float, SkipJsonSchema[None]] = None
+    before: float | SkipJsonSchema[None] = None
+    after: float | SkipJsonSchema[None] = None
     scale: int = 30