From 4e74395b0d42ca54ad4f3804f37686c0e0da08bd Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Wed, 15 Apr 2026 20:55:07 -0500 Subject: [PATCH] prevent review WS handler from poisoning SWR cache before initial fetch completes --- web/src/pages/Events.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/web/src/pages/Events.tsx b/web/src/pages/Events.tsx index d3545f242..9f8dd4e44 100644 --- a/web/src/pages/Events.tsx +++ b/web/src/pages/Events.tsx @@ -334,7 +334,7 @@ export default function Events() { ); useEffect(() => { - if (reviewUpdate?.type === "end") { + if (reviewUpdate?.type === "end" && reviews) { updateSegments( (data) => { if (!data) return data; @@ -348,6 +348,9 @@ export default function Events() { new Map(prev).set(reviewUpdate.after.id, reviewUpdate.after), ); } + // reviews is intentionally excluded - only used to guard against + // updating the SWR cache before data has loaded + // eslint-disable-next-line react-hooks/exhaustive-deps }, [reviewUpdate, updateSegments]); const currentItems = useMemo(() => {