administrator/frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2026-03-29 19:40:19 +03:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

don't mutate with lodash

Browse Source
This commit is contained in:
Josh Hawkins 2026-02-19 13:33:34 -06:00
parent ba3f3683d2
commit 4d9a9811c0
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
web/src/components/config-form/theme/fields/DetectorHardwareField.tsx
View File

@ -6,7 +6,6 @@ import type {
UiSchema, UiSchema,
} from "@rjsf/utils"; } from "@rjsf/utils";
import { toFieldPathId } from "@rjsf/utils"; import { toFieldPathId } from "@rjsf/utils";
import { cloneDeep, set as lodashSet } from "lodash";
import { useCallback, useEffect, useMemo, useState } from "react"; import { useCallback, useEffect, useMemo, useState } from "react";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import { import {
@ -303,9 +302,9 @@ export function DetectorHardwareField(props: FieldProps) {
const updateDetectors = useCallback( const updateDetectors = useCallback(
(nextDetectors: JsonObject, path?: FieldPathList) => { (nextDetectors: JsonObject, path?: FieldPathList) => {
onChange(nextDetectors as unknown, path ?? ([] as FieldPathList)); onChange(nextDetectors as unknown, path ?? fieldPathId.path);
}, },
[onChange], [fieldPathId.path, onChange],
); );
const getTypeLabel = useCallback( const getTypeLabel = useCallback(
@ -595,12 +594,10 @@ export function DetectorHardwareField(props: FieldProps) {
const handleInstanceChange = ( const handleInstanceChange = (
nextValue: unknown, nextValue: unknown,
path: FieldPathList, path: FieldPathList,
_errors?: ErrorSchema, errors?: ErrorSchema,
_id?: string, id?: string,
) => { ) => {
const nextDetectors = cloneDeep(detectors); onChange(nextValue, path, errors, id);
lodashSet(nextDetectors, path, nextValue);
updateDetectors(nextDetectors);
}; };
return ( return (
@ -623,17 +620,16 @@ export function DetectorHardwareField(props: FieldProps) {
}, },
[ [
detectorSchemaByType, detectorSchemaByType,
detectors,
getInstanceUiSchema, getInstanceUiSchema,
disabled, disabled,
errorSchema, errorSchema,
fieldPathId, fieldPathId,
hideError, hideError,
onChange,
onBlur, onBlur,
onFocus, onFocus,
readonly, readonly,
registry, registry,
updateDetectors,
], ],
); );