From 4cbd02d0ef766b543335a6990caf2e136bcf6dd0 Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Wed, 11 Sep 2024 12:17:28 -0500 Subject: [PATCH] simplify --- web/src/views/explore/ExploreView.tsx | 8 ++++---- web/src/views/search/SearchView.tsx | 12 +++--------- 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/web/src/views/explore/ExploreView.tsx b/web/src/views/explore/ExploreView.tsx index 03bebd4bd..3f9f7a3d7 100644 --- a/web/src/views/explore/ExploreView.tsx +++ b/web/src/views/explore/ExploreView.tsx @@ -17,7 +17,7 @@ import useImageLoaded from "@/hooks/use-image-loaded"; import ActivityIndicator from "@/components/indicators/activity-indicator"; type ExploreViewProps = { - onSelectSearch: (searchResult: SearchResult, detail: boolean) => void; + onSelectSearch: (searchResult: SearchResult) => void; }; export default function ExploreView({ onSelectSearch }: ExploreViewProps) { @@ -76,7 +76,7 @@ export default function ExploreView({ onSelectSearch }: ExploreViewProps) { type ThumbnailRowType = { objectType: string; searchResults?: SearchResult[]; - onSelectSearch: (searchResult: SearchResult, detail: boolean) => void; + onSelectSearch: (searchResult: SearchResult) => void; }; function ThumbnailRow({ @@ -145,7 +145,7 @@ function ThumbnailRow({ type ExploreThumbnailImageProps = { event: SearchResult; - onSelectSearch: (searchResult: SearchResult, detail: boolean) => void; + onSelectSearch: (searchResult: SearchResult) => void; }; function ExploreThumbnailImage({ event, @@ -176,7 +176,7 @@ function ExploreThumbnailImage({ loading={isSafari ? "eager" : "lazy"} draggable={false} src={`${apiHost}api/events/${event.id}/thumbnail.jpg`} - onClick={() => onSelectSearch(event, true)} + onClick={() => onSelectSearch(event)} onLoad={() => { onImgLoad(); }} diff --git a/web/src/views/search/SearchView.tsx b/web/src/views/search/SearchView.tsx index a754037b6..366ea813e 100644 --- a/web/src/views/search/SearchView.tsx +++ b/web/src/views/search/SearchView.tsx @@ -65,12 +65,8 @@ export default function SearchView({ // search interaction - const onSelectSearch = useCallback((item: SearchResult, detail: boolean) => { - if (detail) { - setSearchDetail(item); - } else { - setSearchDetail(item); - } + const onSelectSearch = useCallback((item: SearchResult) => { + setSearchDetail(item); }, []); // confidence score - probably needs tweaking @@ -182,9 +178,7 @@ export default function SearchView({ setSimilaritySearch(value)} - onClick={() => { - onSelectSearch(value, true); - }} + onClick={() => onSelectSearch(value)} /> {(searchTerm || similaritySearch) && (