mirror of
https://github.com/blakeblackshear/frigate.git
synced 2026-11-20 04:23:01 +03:00
Optimize review summaries for consistency (#24854)
CI / AMD64 Build (push) Canceled after 0s
CI / AMD64 Smoke Test (push) Canceled after 0s
CI / ARM Build (push) Canceled after 0s
CI / Jetson Jetpack 6 (push) Canceled after 0s
CI / AMD64 Extra Build (push) Canceled after 0s
CI / ARM Extra Build (push) Canceled after 0s
CI / Synaptics Build (push) Canceled after 0s
CI / Assemble and push default build (push) Canceled after 0s
CI / AMD64 Build (push) Canceled after 0s
CI / AMD64 Smoke Test (push) Canceled after 0s
CI / ARM Build (push) Canceled after 0s
CI / Jetson Jetpack 6 (push) Canceled after 0s
CI / AMD64 Extra Build (push) Canceled after 0s
CI / ARM Extra Build (push) Canceled after 0s
CI / Synaptics Build (push) Canceled after 0s
CI / Assemble and push default build (push) Canceled after 0s
This commit is contained in:
@@ -72,6 +72,19 @@ class TestReviewResponseStyle(unittest.TestCase):
|
||||
f"unexpected override fields: {set(overrides)}",
|
||||
)
|
||||
|
||||
def test_every_style_states_length_and_name_rules(self):
|
||||
# The schema caps these fields and grammar-constrained providers cut
|
||||
# text off at the cap, and models only reliably use names when each
|
||||
# field asks for them.
|
||||
for style in ["default", *REVIEW_RESPONSE_STYLES]:
|
||||
fields = get_review_field_guidelines(style)
|
||||
self.assertIn("no more than five sentences", fields["scene"])
|
||||
self.assertIn("one", fields["shortSummary"])
|
||||
self.assertIn("sentence", fields["shortSummary"])
|
||||
|
||||
for field_name in ("scene", "title", "shortSummary"):
|
||||
self.assertIn("always use their name", fields[field_name])
|
||||
|
||||
def test_config_enum_matches_style_presets(self):
|
||||
enum_styles = {e.value for e in ReviewResponseStyleEnum}
|
||||
self.assertEqual(enum_styles, {"default", *REVIEW_RESPONSE_STYLES})
|
||||
|
||||
Reference in New Issue
Block a user