administrator/frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2026-03-20 23:28:23 +03:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

update instructions to prevent exposing exception info

Browse Source
This commit is contained in:
Josh Hawkins 2026-03-02 08:26:06 -06:00
parent 811daed4c1
commit 4606a7bc39
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
.github/copilot-instructions.md vendored
View File

@ -324,6 +324,12 @@ try:
value = await sensor.read() value = await sensor.read()
except Exception: # ❌ Too broad except Exception: # ❌ Too broad
logger.error("Failed") logger.error("Failed")
# Returning exceptions in JSON responses
except ValueError as e:
return JSONResponse(
content={"success": False, "message": str(e)},
)
``` ```
### ✅ Use These Instead ### ✅ Use These Instead
@ -353,6 +359,16 @@ try:
value = await sensor.read() value = await sensor.read()
except SensorException as err: # ✅ Specific except SensorException as err: # ✅ Specific
logger.exception("Failed to read sensor") logger.exception("Failed to read sensor")
# Safe error responses
except ValueError:
logger.exception("Invalid parameters for API request")
return JSONResponse(
content={
"success": False,
"message": "Invalid request parameters",
},
)
``` ```
## Project-Specific Conventions ## Project-Specific Conventions