Miscellaneous fixes (#23082)

* openvino log message and preview directory checks

* restrict config vars for viewer users

* recording timestamp fix

when startTime is exactly on an hour boundary, findIndex returns the first matching chunk, which is the previous hour's chunk (where before == startTime), instead of the correct chunk (where after == startTime)

the bug shows up when using the share timestamp feature and sharing a specific timestamp on the exact hour mark. when accessing the shared link, the timeline would jump to the incorrect hour

* use helper for chunked time range

* Adjustments to contributing docs

* tweak

* Improve wording

* tweak

---------

Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>

web/src/utils/timelineUtil.tsx

@@ -38,6 +38,22 @@ export function getChunkedTimeDay(timeRange: TimeRange): TimeRange[] {
   return data;
 }
 
+/**
+ * Find the chunk index that contains the given timestamp.
+ * Uses half-open intervals [after, before) for all chunks except the last,
+ * which uses a closed interval [after, before] so the terminal boundary
+ * is always reachable.
+ */
+export function findChunkIndex(chunks: TimeRange[], timestamp: number): number {
+  return chunks.findIndex((chunk, i) => {
+    const isLast = i === chunks.length - 1;
+    return (
+      chunk.after <= timestamp &&
+      (isLast ? chunk.before >= timestamp : chunk.before > timestamp)
+    );
+  });
+}
+
 export function getChunkedTimeRange(
   startTimestamp: number,
   endTimestamp: number,

web/src/views/recording/RecordingView.tsx

@@ -26,7 +26,7 @@ import {
   ReviewSummary,
   ZoomLevel,
 } from "@/types/review";
-import { getChunkedTimeDay } from "@/utils/timelineUtil";
+import { findChunkIndex, getChunkedTimeDay } from "@/utils/timelineUtil";
 import {
   MutableRefObject,
   useCallback,
@@ -169,9 +169,7 @@ export function RecordingView({
     [timeRange],
   );
   const [selectedRangeIdx, setSelectedRangeIdx] = useState(
-    chunkedTimeRange.findIndex((chunk) => {
-      return chunk.after <= startTime && chunk.before >= startTime;
-    }),
+    findChunkIndex(chunkedTimeRange, startTime),
   );
   const currentTimeRange = useMemo<TimeRange>(
     () =>
@@ -274,9 +272,7 @@ export function RecordingView({
 
   const updateSelectedSegment = useCallback(
     (currentTime: number, updateStartTime: boolean) => {
-      const index = chunkedTimeRange.findIndex(
-        (seg) => seg.after <= currentTime && seg.before >= currentTime,
-      );
+      const index = findChunkIndex(chunkedTimeRange, currentTime);
 
       if (index != -1) {
         if (updateStartTime) {