From b84ce4ed51b430e6915f7e7373680a63c4810a2a Mon Sep 17 00:00:00 2001
From: Andrii Podanenko <podarokua@gmail.com>
Date: Fri, 24 Mar 2023 17:30:29 +0200
Subject: [PATCH] feat: no-aio. Add todos

---
 docker/build_nginx.sh  | 6 +++---
 docker/install_deps.sh | 1 +
 docker/mpp.sh          | 1 +
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/docker/build_nginx.sh b/docker/build_nginx.sh
index 3927ce1d2..6ee4e80ba 100755
--- a/docker/build_nginx.sh
+++ b/docker/build_nginx.sh
@@ -9,11 +9,12 @@ RTMP_MODULE_VERSION="1.2.1"
 
 cp /etc/apt/sources.list /etc/apt/sources.list.d/sources-src.list
 sed -i 's|deb http|deb-src http|g' /etc/apt/sources.list.d/sources-src.list
-apt-get update
+apt-get -qq update
 
 apt-get -yqq build-dep nginx
 
-apt-get -yqq install --no-install-recommends ca-certificates wget
+# TODO: move all apt-get installs to dedicated script for having it in a single Docker layer = performance of reruns.
+apt-get -yqq install --no-install-recommends ca-certificates wget libaio-dev
 update-ca-certificates -f
 mkdir /tmp/nginx
 wget -nv https://nginx.org/download/nginx-${NGINX_VERSION}.tar.gz
@@ -60,7 +61,6 @@ if [ "$ARCH" = "aarch64" ]; then
 fi
 
 ./configure --prefix=/usr/local/nginx \
-    --with-file-aio \
     --with-http_sub_module \
     --with-http_ssl_module \
     --with-threads \
diff --git a/docker/install_deps.sh b/docker/install_deps.sh
index 484d45c61..4d20098ba 100755
--- a/docker/install_deps.sh
+++ b/docker/install_deps.sh
@@ -4,6 +4,7 @@ set -euxo pipefail
 
 apt-get -qq update
 
+# TODO: move all apt-get installs to dedicated script for having it in a single Docker layer = performance of reruns.
 apt-get -qq install --no-install-recommends -y \
     apt-transport-https \
     gnupg \
diff --git a/docker/mpp.sh b/docker/mpp.sh
index b86e03eee..b15660107 100755
--- a/docker/mpp.sh
+++ b/docker/mpp.sh
@@ -10,6 +10,7 @@ if [ -e /usr/local/include/mpp/mpp.h ] || [ -e /usr/include/mpp/mpp.h ] || pkg-c
 else
 # Install mpp from sources
 apt-get -qq update
+# TODO: move all apt-get installs to dedicated script for having it in a single Docker layer = performance of reruns.
 apt-get install -y git build-essential yasm pkg-config \
 libtool coreutils autoconf automake build-essential cmake \
 doxygen git graphviz imagemagick libasound2-dev libass-dev \