Face fixes (#17618)

* Correctly ensure updates are more periodic when lpr or face detection is needed

* Cleanup

* Update api schema

* Don't update for stationary objects

* Simplify check

* Remove

frigate/api/classification.py

@@ -250,12 +250,6 @@ def deregister_faces(request: Request, name: str, body: dict = None):
     json: dict[str, any] = body or {}
     list_of_ids = json.get("ids", "")
 
-    if not list_of_ids or len(list_of_ids) == 0:
-        return JSONResponse(
-            content=({"success": False, "message": "Not a valid list of ids"}),
-            status_code=404,
-        )
-
     context: EmbeddingsContext = request.app.embeddings
     context.delete_face_ids(
         name, map(lambda file: sanitize_filename(file), list_of_ids)

frigate/camera/state.py

@@ -53,17 +53,6 @@ class CameraState:
         self.callbacks = defaultdict(list)
         self.ptz_autotracker_thread = ptz_autotracker_thread
         self.prev_enabled = self.camera_config.enabled
-        self.requires_face_detection = (
-            self.config.face_recognition.enabled
-            and "face" not in self.config.objects.all_objects
-        )
-
-    def get_max_update_frequency(self, obj: TrackedObject) -> int:
-        return (
-            1
-            if self.requires_face_detection and obj.obj_data["label"] == "person"
-            else 5
-        )
 
     def get_current_frame(self, draw_options: dict[str, Any] = {}):
         with self.current_frame_lock:
@@ -280,8 +269,10 @@ class CameraState:
 
         for id in updated_ids:
             updated_obj = tracked_objects[id]
-            thumb_update, significant_update, autotracker_update = updated_obj.update(
-                frame_time, current_detections[id], current_frame is not None
+            thumb_update, significant_update, path_update, autotracker_update = (
+                updated_obj.update(
+                    frame_time, current_detections[id], current_frame is not None
+                )
             )
 
             if autotracker_update or significant_update:
@@ -298,14 +289,18 @@ class CameraState:
 
                 updated_obj.last_updated = frame_time
 
-            # if it has been more than max_update_frequency seconds since the last thumb update
+            # if it has been more than 5 seconds since the last thumb update
             # and the last update is greater than the last publish or
-            # the object has changed significantly
+            # the object has changed significantly or
+            # the object moved enough to update the path
             if (
-                frame_time - updated_obj.last_published
-                > self.get_max_update_frequency(updated_obj)
-                and updated_obj.last_updated > updated_obj.last_published
-            ) or significant_update:
+                (
+                    frame_time - updated_obj.last_published > 5
+                    and updated_obj.last_updated > updated_obj.last_published
+                )
+                or significant_update
+                or path_update
+            ):
                 # call event handlers
                 for c in self.callbacks["update"]:
                     c(self.name, updated_obj, frame_name)

frigate/track/tracked_object.py

@@ -117,6 +117,7 @@ class TrackedObject:
     def update(self, current_frame_time: float, obj_data, has_valid_frame: bool):
         thumb_update = False
         significant_change = False
+        path_update = False
         autotracker_update = False
         # if the object is not in the current frame, add a 0.0 to the score history
         if obj_data["frame_time"] != current_frame_time:
@@ -324,19 +325,21 @@ class TrackedObject:
 
             if not self.path_data:
                 self.path_data.append((bottom_center, obj_data["frame_time"]))
+                path_update = True
             elif (
                 math.dist(self.path_data[-1][0], bottom_center) >= threshold
                 or len(self.path_data) == 1
             ):
                 # check Euclidean distance before appending
                 self.path_data.append((bottom_center, obj_data["frame_time"]))
+                path_update = True
                 logger.debug(
                     f"Point tracking: {obj_data['id']}, {bottom_center}, {obj_data['frame_time']}"
                 )
 
         self.obj_data.update(obj_data)
         self.current_zones = current_zones
-        return (thumb_update, significant_change, autotracker_update)
+        return (thumb_update, significant_change, path_update, autotracker_update)
 
     def to_dict(self):
         event = {