From 32f6114573999fb7150530739b6413a5e2dde5b2 Mon Sep 17 00:00:00 2001
From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>
Date: Thu, 15 Jan 2026 20:41:39 -0600
Subject: [PATCH] misc triggers tweaks

i18n fixes
fix toaster color
fix clicking on labels selecting incorrect checkbox
---
 web/public/locales/en/common.json                   |  1 +
 web/src/components/overlay/CreateTriggerDialog.tsx  | 13 ++++++++-----
 .../trigger/wizard/Step3ThresholdAndActions.tsx     | 11 +++++++----
 web/src/views/settings/TriggerView.tsx              | 11 +++++++----
 4 files changed, 23 insertions(+), 13 deletions(-)

diff --git a/web/public/locales/en/common.json b/web/public/locales/en/common.json
index 2ae6297a1..8bf13ca61 100644
--- a/web/public/locales/en/common.json
+++ b/web/public/locales/en/common.json
@@ -3,6 +3,7 @@
     "untilForTime": "Until {{time}}",
     "untilForRestart": "Until Frigate restarts.",
     "untilRestart": "Until restart",
+    "never": "Never",
     "ago": "{{timeAgo}} ago",
     "justNow": "Just now",
     "today": "Today",
diff --git a/web/src/components/overlay/CreateTriggerDialog.tsx b/web/src/components/overlay/CreateTriggerDialog.tsx
index 11734acaf..ef30c649d 100644
--- a/web/src/components/overlay/CreateTriggerDialog.tsx
+++ b/web/src/components/overlay/CreateTriggerDialog.tsx
@@ -268,7 +268,7 @@ export default function CreateTriggerDialog({
                 <FormItem className="flex flex-row items-center justify-between">
                   <div className="space-y-0.5">
                     <FormLabel className="text-base">
-                      {t("enabled", { ns: "common" })}
+                      {t("button.enabled", { ns: "common" })}
                     </FormLabel>
                     <div className="text-sm text-muted-foreground">
                       {t("triggers.dialog.form.enabled.description")}
@@ -394,7 +394,10 @@ export default function CreateTriggerDialog({
                   </FormLabel>
                   <div className="space-y-2">
                     {availableActions.map((action) => (
-                      <div key={action} className="flex items-center space-x-2">
+                      <label
+                        key={action}
+                        className="flex cursor-pointer items-center space-x-2"
+                      >
                         <FormControl>
                           <Checkbox
                             checked={form
@@ -416,10 +419,10 @@ export default function CreateTriggerDialog({
                             }}
                           />
                         </FormControl>
-                        <FormLabel className="text-sm font-normal">
+                        <span className="text-sm font-normal">
                           {t(`triggers.actions.${action}`)}
-                        </FormLabel>
-                      </div>
+                        </span>
+                      </label>
                     ))}
                   </div>
                   <FormDescription>
diff --git a/web/src/components/trigger/wizard/Step3ThresholdAndActions.tsx b/web/src/components/trigger/wizard/Step3ThresholdAndActions.tsx
index 33568dca7..db82febb4 100644
--- a/web/src/components/trigger/wizard/Step3ThresholdAndActions.tsx
+++ b/web/src/components/trigger/wizard/Step3ThresholdAndActions.tsx
@@ -142,7 +142,10 @@ export default function Step3ThresholdAndActions({
               <FormLabel>{t("triggers.dialog.form.actions.title")}</FormLabel>
               <div className="space-y-2">
                 {availableActions.map((action) => (
-                  <div key={action} className="flex items-center space-x-2">
+                  <label
+                    key={action}
+                    className="flex cursor-pointer items-center space-x-2"
+                  >
                     <FormControl>
                       <Checkbox
                         checked={form
@@ -164,10 +167,10 @@ export default function Step3ThresholdAndActions({
                         }}
                       />
                     </FormControl>
-                    <FormLabel className="text-sm font-normal">
+                    <span className="text-sm font-normal">
                       {t(`triggers.actions.${action}`)}
-                    </FormLabel>
-                  </div>
+                    </span>
+                  </label>
                 ))}
               </div>
               <FormDescription>
diff --git a/web/src/views/settings/TriggerView.tsx b/web/src/views/settings/TriggerView.tsx
index 7448a210b..28aa148fe 100644
--- a/web/src/views/settings/TriggerView.tsx
+++ b/web/src/views/settings/TriggerView.tsx
@@ -1,6 +1,7 @@
 import { useCallback, useEffect, useMemo, useState } from "react";
 import { Trans, useTranslation } from "react-i18next";
-import { Toaster, toast } from "sonner";
+import { toast } from "sonner";
+import { Toaster } from "@/components/ui/sonner";
 import useSWR from "swr";
 import axios from "axios";
 import { Button } from "@/components/ui/button";
@@ -598,7 +599,7 @@ export default function TriggerView({
                                           date_style: "medium",
                                         },
                                       )
-                                    : "Never"}
+                                    : t("never", { ns: "common" })}
                                 </span>
                                 {trigger_status?.triggers[trigger.name]
                                   ?.triggering_event_id && (
@@ -663,7 +664,9 @@ export default function TriggerView({
                     <TableHeader className="sticky top-0 bg-muted/50">
                       <TableRow>
                         <TableHead className="w-4"></TableHead>
-                        <TableHead>{t("name", { ns: "common" })}</TableHead>
+                        <TableHead>
+                          {t("name", { ns: "triggers.table.name" })}
+                        </TableHead>
                         <TableHead>{t("triggers.table.type")}</TableHead>
                         <TableHead>
                           {t("triggers.table.lastTriggered")}
@@ -759,7 +762,7 @@ export default function TriggerView({
                                           date_style: "medium",
                                         },
                                       )
-                                    : "Never"}
+                                    : t("time.never", { ns: "common" })}
                                 </span>
                                 {trigger_status?.triggers[trigger.name]
                                   ?.triggering_event_id && (