administrator/frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2026-03-11 10:57:38 +03:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

remove show advanced fields switch

Browse Source
This commit is contained in:
Josh Hawkins 2026-01-26 10:50:54 -06:00
parent f534c7216a
commit 25aaa2d9f7
1 changed files with 6 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
web/src/components/config-form/ConfigForm.tsx
View File

@ -6,11 +6,9 @@ import type { IChangeEvent } from "@rjsf/core";
import { frigateTheme } from "./theme"; import { frigateTheme } from "./theme";
import { transformSchema } from "@/lib/config-schema"; import { transformSchema } from "@/lib/config-schema";
import { createErrorTransformer } from "@/lib/config-schema/errorMessages"; import { createErrorTransformer } from "@/lib/config-schema/errorMessages";
import { useMemo, useCallback, useState } from "react"; import { useMemo, useCallback } from "react";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import { cn } from "@/lib/utils"; import { cn } from "@/lib/utils";
import { Switch } from "@/components/ui/switch";
import { Label } from "@/components/ui/label";
export interface ConfigFormProps { export interface ConfigFormProps {
/** JSON Schema for the form */ /** JSON Schema for the form */
@ -64,7 +62,7 @@ export function ConfigForm({
readonly = false, readonly = false,
showSubmit = true, showSubmit = true,
className, className,
liveValidate = false, liveValidate = true,
formContext, formContext,
i18nNamespace, i18nNamespace,
}: ConfigFormProps) { }: ConfigFormProps) {
@ -73,16 +71,11 @@ export function ConfigForm({
"views/settings", "views/settings",
"config/validation", "config/validation",
]); ]);
const [showAdvanced, setShowAdvanced] = useState(false);
// Determine which fields to hide based on advanced toggle // Determine which fields to hide based on advanced toggle
const effectiveHiddenFields = useMemo(() => { const effectiveHiddenFields = useMemo(() => {
if (showAdvanced || !advancedFields || advancedFields.length === 0) { return hiddenFields;
return hiddenFields; }, [hiddenFields]);
}
// Hide advanced fields when toggle is off
return [...(hiddenFields || []), ...advancedFields];
}, [hiddenFields, advancedFields, showAdvanced]);
// Transform schema and generate uiSchema // Transform schema and generate uiSchema
const { schema: transformedSchema, uiSchema: generatedUiSchema } = useMemo( const { schema: transformedSchema, uiSchema: generatedUiSchema } = useMemo(
@ -90,17 +83,10 @@ export function ConfigForm({
transformSchema(schema, { transformSchema(schema, {
fieldOrder, fieldOrder,
hiddenFields: effectiveHiddenFields, hiddenFields: effectiveHiddenFields,
advancedFields: showAdvanced ? advancedFields : [], advancedFields: advancedFields,
i18nNamespace, i18nNamespace,
}), }),
[ [schema, fieldOrder, effectiveHiddenFields, advancedFields, i18nNamespace],
schema,
fieldOrder,
effectiveHiddenFields,
advancedFields,
showAdvanced,
i18nNamespace,
],
); );
// Merge generated uiSchema with custom overrides // Merge generated uiSchema with custom overrides
@ -133,8 +119,6 @@ export function ConfigForm({
[onSubmit], [onSubmit],
); );
const hasAdvancedFields = advancedFields && advancedFields.length > 0;
// Extended form context with i18n info // Extended form context with i18n info
const extendedFormContext = useMemo( const extendedFormContext = useMemo(
() => ({ () => ({
@ -147,24 +131,6 @@ export function ConfigForm({
return ( return (
<div className={cn("config-form", className)}> <div className={cn("config-form", className)}>
{hasAdvancedFields && (
<div className="mb-4 flex items-center justify-end gap-2">
<Switch
id="show-advanced"
checked={showAdvanced}
onCheckedChange={setShowAdvanced}
/>
<Label
htmlFor="show-advanced"
className="cursor-pointer text-sm text-muted-foreground"
>
{t("configForm.showAdvanced", {
ns: "views/settings",
defaultValue: "Show Advanced Settings",
})}
</Label>
</div>
)}
<Form <Form
schema={transformedSchema} schema={transformedSchema}
uiSchema={finalUiSchema} uiSchema={finalUiSchema}