Add login page docs hint (#20619)

* add config field

* add endpoint

* set config var when onboarding

* add no auth exception to nginx config

* form changes and i18n

* clean up
This commit is contained in:
Josh Hawkins 2025-10-22 12:24:53 -05:00 committed by GitHub
parent d6f5d2b0fa
commit 2387dccc19
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 73 additions and 1 deletions

View File

@ -274,6 +274,18 @@ http {
include proxy.conf; include proxy.conf;
} }
# Allow unauthenticated access to the first_time_login endpoint
# so the login page can load help text before authentication.
location /api/auth/first_time_login {
auth_request off;
limit_except GET {
deny all;
}
rewrite ^/api(/.*)$ $1 break;
proxy_pass http://frigate_api;
include proxy.conf;
}
location /api/stats { location /api/stats {
include auth_request.conf; include auth_request.conf;
access_log off; access_log off;

View File

@ -35,6 +35,23 @@ logger = logging.getLogger(__name__)
router = APIRouter(tags=[Tags.auth]) router = APIRouter(tags=[Tags.auth])
@router.get("/auth/first_time_login")
def first_time_login(request: Request):
"""Return whether the admin first-time login help flag is set in config.
This endpoint is intentionally unauthenticated so the login page can
query it before a user is authenticated.
"""
auth_config = request.app.frigate_config.auth
return JSONResponse(
content={
"admin_first_time_login": auth_config.admin_first_time_login
or auth_config.reset_admin_password
}
)
class RateLimiter: class RateLimiter:
_limit = "" _limit = ""
@ -515,6 +532,11 @@ def login(request: Request, body: AppPostLoginBody):
set_jwt_cookie( set_jwt_cookie(
response, JWT_COOKIE_NAME, encoded_jwt, expiration, JWT_COOKIE_SECURE response, JWT_COOKIE_NAME, encoded_jwt, expiration, JWT_COOKIE_SECURE
) )
# Clear admin_first_time_login flag after successful admin login so the
# UI stops showing the first-time login documentation link.
if role == "admin":
request.app.frigate_config.auth.admin_first_time_login = False
return response return response
return JSONResponse(content={"message": "Login failed"}, status_code=401) return JSONResponse(content={"message": "Login failed"}, status_code=401)

View File

@ -488,6 +488,8 @@ class FrigateApp:
} }
).execute() ).execute()
self.config.auth.admin_first_time_login = True
logger.info("********************************************************") logger.info("********************************************************")
logger.info("********************************************************") logger.info("********************************************************")
logger.info("*** Auth is enabled, but no users exist. ***") logger.info("*** Auth is enabled, but no users exist. ***")

View File

@ -38,6 +38,13 @@ class AuthConfig(FrigateBaseModel):
default_factory=dict, default_factory=dict,
title="Role to camera mappings. Empty list grants access to all cameras.", title="Role to camera mappings. Empty list grants access to all cameras.",
) )
admin_first_time_login: Optional[bool] = Field(
default=False,
title="Internal field to expose first-time admin login flag to the UI",
description=(
"When true the UI may show a help link on the login page informing users how to sign in after an admin password reset. "
),
)
@field_validator("roles") @field_validator("roles")
@classmethod @classmethod

View File

@ -3,6 +3,7 @@
"user": "Username", "user": "Username",
"password": "Password", "password": "Password",
"login": "Login", "login": "Login",
"firstTimeLogin": "Trying to log in for the first time? Credentials are printed in the Frigate logs.",
"errors": { "errors": {
"usernameRequired": "Username is required", "usernameRequired": "Username is required",
"passwordRequired": "Password is required", "passwordRequired": "Password is required",

View File

@ -22,14 +22,24 @@ import { zodResolver } from "@hookform/resolvers/zod";
import { z } from "zod"; import { z } from "zod";
import { AuthContext } from "@/context/auth-context"; import { AuthContext } from "@/context/auth-context";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import useSWR from "swr";
import { LuExternalLink } from "react-icons/lu";
import { useDocDomain } from "@/hooks/use-doc-domain";
import { Card, CardContent } from "@/components/ui/card";
interface UserAuthFormProps extends React.HTMLAttributes<HTMLDivElement> {} interface UserAuthFormProps extends React.HTMLAttributes<HTMLDivElement> {}
export function UserAuthForm({ className, ...props }: UserAuthFormProps) { export function UserAuthForm({ className, ...props }: UserAuthFormProps) {
const { t } = useTranslation(["components/auth"]); const { t } = useTranslation(["components/auth", "common"]);
const { getLocaleDocUrl } = useDocDomain();
const [isLoading, setIsLoading] = React.useState<boolean>(false); const [isLoading, setIsLoading] = React.useState<boolean>(false);
const { login } = React.useContext(AuthContext); const { login } = React.useContext(AuthContext);
// need to use local fetcher because useSWR default fetcher is not set up in this context
const fetcher = (path: string) => axios.get(path).then((res) => res.data);
const { data } = useSWR("/auth/first_time_login", fetcher);
const showFirstTimeLink = data?.admin_first_time_login === true;
const formSchema = z.object({ const formSchema = z.object({
user: z.string().min(1, t("form.errors.usernameRequired")), user: z.string().min(1, t("form.errors.usernameRequired")),
password: z.string().min(1, t("form.errors.passwordRequired")), password: z.string().min(1, t("form.errors.passwordRequired")),
@ -136,6 +146,24 @@ export function UserAuthForm({ className, ...props }: UserAuthFormProps) {
</div> </div>
</form> </form>
</Form> </Form>
{showFirstTimeLink && (
<Card className="mt-4 p-4 text-center text-sm">
<CardContent className="p-2">
<p className="mb-2 text-primary-variant">
{t("form.firstTimeLogin")}
</p>
<a
href={getLocaleDocUrl("configuration/authentication#onboarding")}
target="_blank"
rel="noopener noreferrer"
className="inline-flex items-center text-primary"
>
{t("readTheDocumentation", { ns: "common" })}
<LuExternalLink className="ml-2 size-3" />
</a>
</CardContent>
</Card>
)}
<Toaster /> <Toaster />
</div> </div>
); );