Remove parents in remove_empty_directories (#21726)

The original implementation did a full directory tree walk to find and remove
empty directories, so this implementation should remove the parents as well,
like the original did.

frigate/record/cleanup.py

@@ -11,7 +11,7 @@ from pathlib import Path
 from playhouse.sqlite_ext import SqliteExtDatabase
 
 from frigate.config import CameraConfig, FrigateConfig, RetainModeEnum
-from frigate.const import CACHE_DIR, CLIPS_DIR, MAX_WAL_SIZE
+from frigate.const import CACHE_DIR, CLIPS_DIR, MAX_WAL_SIZE, RECORD_DIR
 from frigate.models import Previews, Recordings, ReviewSegment, UserReviewStatus
 from frigate.util.builtin import clear_and_unlink
 from frigate.util.media import remove_empty_directories
@@ -376,5 +376,5 @@ class RecordingCleanup(threading.Thread):
             if counter == 0:
                 self.clean_tmp_clips()
                 maybe_empty_dirs = self.expire_recordings()
-                remove_empty_directories(maybe_empty_dirs)
+                remove_empty_directories(Path(RECORD_DIR), maybe_empty_dirs)
                 self.truncate_wal()

frigate/util/media.py

@@ -50,22 +50,36 @@ class SyncResult:
         }
 
 
-def remove_empty_directories(paths: Iterable[Path]) -> None:
+def remove_empty_directories(root: Path, paths: Iterable[Path]) -> None:
     """
     Remove directories if they exist and are empty.
     Silently ignores non-existent and non-empty directories.
+    Attempts to remove parent directories as well, stopping at the given root.
     """
     count = 0
-    for path in paths:
+    while True:
-        try:
+        parents = set()
-            path.rmdir()
+        for path in paths:
-        except FileNotFoundError:
+            if path == root:
-            continue
-        except OSError as e:
-            if e.errno == errno.ENOTEMPTY:
                 continue
-            raise
+
-        count += 1
+            try:
+                path.rmdir()
+                count += 1
+            except FileNotFoundError:
+                pass
+            except OSError as e:
+                if e.errno == errno.ENOTEMPTY:
+                    continue
+                raise
+
+            parents.add(path.parent)
+
+        if not parents:
+            break
+
+        paths = parents
+
     logger.debug("Removed {count} empty directories")