From 16220ede0c8adcb942a65e7a49a52275f043a3ca Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Wed, 25 Jun 2025 15:31:52 -0500 Subject: [PATCH] Ensure onvif move request has a valid speed before removing When autotracking zooming is set to `disabled` (or is left out of the config), move_request["Speed"] may not exist, depending on the camera --- frigate/ptz/onvif.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/frigate/ptz/onvif.py b/frigate/ptz/onvif.py index edba6222f..81c8b9852 100644 --- a/frigate/ptz/onvif.py +++ b/frigate/ptz/onvif.py @@ -265,9 +265,15 @@ class OnvifController: "RelativeZoomTranslationSpace" ][zoom_space_id]["URI"] else: - if "Zoom" in move_request["Translation"]: + if ( + move_request["Translation"] is not None + and "Zoom" in move_request["Translation"] + ): del move_request["Translation"]["Zoom"] - if "Zoom" in move_request["Speed"]: + if ( + move_request["Speed"] is not None + and "Zoom" in move_request["Speed"] + ): del move_request["Speed"]["Zoom"] logger.debug( f"{camera_name}: Relative move request after deleting zoom: {move_request}"