From 0f4ebb812eb4216bcfad998d9acef0c608599d45 Mon Sep 17 00:00:00 2001 From: Nicolas Mowen Date: Sun, 28 Dec 2025 06:39:44 -0700 Subject: [PATCH] Show event in all cases, even without non-none match --- web/src/pages/FaceLibrary.tsx | 4 +-- .../classification/ModelTrainingView.tsx | 36 +++++++------------ 2 files changed, 14 insertions(+), 26 deletions(-) diff --git a/web/src/pages/FaceLibrary.tsx b/web/src/pages/FaceLibrary.tsx index 628928562..8ad6f70e5 100644 --- a/web/src/pages/FaceLibrary.tsx +++ b/web/src/pages/FaceLibrary.tsx @@ -925,11 +925,11 @@ function FaceAttemptGroup({ [onRefresh, t], ); - // Create ClassifiedEvent from Event (face recognition uses sub_label) const classifiedEvent: ClassifiedEvent | undefined = useMemo(() => { - if (!event || !event.sub_label || event.sub_label === "none") { + if (!event) { return undefined; } + return { id: event.id, label: event.sub_label, diff --git a/web/src/views/classification/ModelTrainingView.tsx b/web/src/views/classification/ModelTrainingView.tsx index 31e6f6d53..ec7ce0472 100644 --- a/web/src/views/classification/ModelTrainingView.tsx +++ b/web/src/views/classification/ModelTrainingView.tsx @@ -1043,34 +1043,22 @@ function ObjectTrainGrid({ return undefined; } - const classificationType = model.object_config.classification_type; + let label: string | undefined = undefined; + let score: number | undefined = undefined; - if (classificationType === "attribute") { - // For attribute type, look at event.data[model.name] - const attributeValue = event.data[model.name] as string | undefined; - const attributeScore = event.data[`${model.name}_score`] as - | number - | undefined; - - if (attributeValue && attributeValue !== "none") { - return { - id: event.id, - label: attributeValue, - score: attributeScore, - }; - } + if (model.object_config.classification_type === "attribute") { + label = event.data[model.name] as string | undefined; + score = event.data[`${model.name}_score`] as number | undefined; } else { - // For sub_label type, use event.sub_label - if (event.sub_label && event.sub_label !== "none") { - return { - id: event.id, - label: event.sub_label, - score: event.data?.sub_label_score, - }; - } + label = event.sub_label; + score = event.data.sub_label_score; } - return undefined; + return { + id: event.id, + label: label, + score: score, + }; }, [model], );