administrator/frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2026-07-04 19:11:14 +03:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

add collapsible main nav items in settings

Browse Source
This commit is contained in:
Josh Hawkins 2026-05-24 07:17:33 -05:00
parent d47ac788c0
commit 0cb030420e
1 changed files with 146 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

214
web/src/pages/Settings.tsx
View File

@ -16,6 +16,11 @@ import {
AlertDialogTitle, AlertDialogTitle,
} from "@/components/ui/alert-dialog"; } from "@/components/ui/alert-dialog";
import { Drawer, DrawerContent, DrawerTrigger } from "@/components/ui/drawer"; import { Drawer, DrawerContent, DrawerTrigger } from "@/components/ui/drawer";
import {
Collapsible,
CollapsibleContent,
CollapsibleTrigger,
} from "@/components/ui/collapsible";
import { Button } from "@/components/ui/button"; import { Button } from "@/components/ui/button";
import { import {
useCallback, useCallback,
@ -589,7 +594,7 @@ function MobileMenuItem({
return ( return (
<div <div
className={cn( className={cn(
"inline-flex h-10 w-full cursor-pointer items-center justify-between whitespace-nowrap rounded-md px-4 py-2 pr-2 text-sm font-medium text-primary-variant disabled:pointer-events-none disabled:opacity-50", "inline-flex h-10 w-full cursor-pointer items-center whitespace-nowrap rounded-md px-4 py-2 text-sm font-medium text-primary-variant disabled:pointer-events-none disabled:opacity-50",
className, className,
)} )}
onClick={() => { onClick={() => {
@ -600,7 +605,6 @@ function MobileMenuItem({
<div className="w-full"> <div className="w-full">
{label ?? <div>{t("menu." + item.key)}</div>} {label ?? <div>{t("menu." + item.key)}</div>}
</div> </div>
<LuChevronRight className="size-4" />
</div> </div>
); );
} }
@ -613,6 +617,39 @@ export default function Settings() {
const [sectionStatusByKey, setSectionStatusByKey] = useState< const [sectionStatusByKey, setSectionStatusByKey] = useState<
Partial<Record<SettingsType, SectionStatus>> Partial<Record<SettingsType, SectionStatus>>
>({}); >({});
const [collapsedGroups, setCollapsedGroups] = useState<Set<string>>(
() =>
// all collapsed by default
new Set(
settingsGroups.filter((g) => g.items.length > 1).map((g) => g.label),
),
);
const toggleGroupCollapsed = useCallback((label: string) => {
setCollapsedGroups((prev) => {
const next = new Set(prev);
if (next.has(label)) {
next.delete(label);
} else {
next.add(label);
}
return next;
});
}, []);
// Auto-expand the group containing the active page whenever pageToggle changes
useEffect(() => {
const containingGroup = settingsGroups.find((group) =>
group.items.some((item) => item.key === pageToggle),
);
if (!containingGroup) return;
setCollapsedGroups((prev) => {
if (!prev.has(containingGroup.label)) return prev;
const next = new Set(prev);
next.delete(containingGroup.label);
return next;
});
}, [pageToggle]);
const { data: config } = useSWR<FrigateConfig>("config"); const { data: config } = useSWR<FrigateConfig>("config");
const { data: profilesData } = useSWR<ProfilesApiResponse>("profiles"); const { data: profilesData } = useSWR<ProfilesApiResponse>("profiles");
@ -1611,34 +1648,49 @@ export default function Settings() {
visibleSettingsViews.includes(item.key as SettingsType), visibleSettingsViews.includes(item.key as SettingsType),
); );
if (filteredItems.length === 0) return null; if (filteredItems.length === 0) return null;
const isMultiItem = filteredItems.length > 1;
const renderedExpanded =
!isMultiItem || !collapsedGroups.has(group.label);
const items = filteredItems.map((item) => (
<MobileMenuItem
key={item.key}
item={item}
className={cn(filteredItems.length == 1 && "pl-2")}
label={renderMenuItemLabel(item.key as SettingsType)}
onSelect={(key) => {
if (
!isAdmin &&
!ALLOWED_VIEWS_FOR_VIEWER.includes(key as SettingsType)
) {
setPageToggle("uiSettings");
} else {
setPageToggle(key as SettingsType);
}
setContentMobileOpen(true);
}}
/>
));
return ( return (
<div key={group.label} className="mb-3"> <div key={group.label} className="mb-3">
{filteredItems.length > 1 && ( {isMultiItem ? (
<h3 className="mb-2 ml-2 text-sm font-medium text-secondary-foreground"> <Collapsible
<div>{t("menu." + group.label)}</div> open={renderedExpanded}
</h3> onOpenChange={() => toggleGroupCollapsed(group.label)}
>
<CollapsibleTrigger className="flex min-h-10 w-full items-center justify-between rounded-md py-2 pl-2 pr-2 text-sm font-medium text-secondary-foreground">
<div>{t("menu." + group.label)}</div>
<LuChevronRight
className={cn(
"size-4 shrink-0 transition-transform duration-200",
renderedExpanded && "rotate-90",
)}
/>
</CollapsibleTrigger>
<CollapsibleContent>{items}</CollapsibleContent>
</Collapsible>
) : (
items
)} )}
{filteredItems.map((item) => (
<MobileMenuItem
key={item.key}
item={item}
className={cn(filteredItems.length == 1 && "pl-2")}
label={renderMenuItemLabel(item.key as SettingsType)}
onSelect={(key) => {
if (
!isAdmin &&
!ALLOWED_VIEWS_FOR_VIEWER.includes(
key as SettingsType,
)
) {
setPageToggle("uiSettings");
} else {
setPageToggle(key as SettingsType);
}
setContentMobileOpen(true);
}}
/>
))}
</div> </div>
); );
})} })}
@ -1940,48 +1992,74 @@ export default function Settings() {
</SidebarMenuItem> </SidebarMenuItem>
</SidebarMenu> </SidebarMenu>
) : ( ) : (
<> (() => {
<SidebarGroupLabel const hasActiveItem = filteredItems.some(
className={cn( (item) => pageToggle === item.key,
"ml-2 cursor-default pl-0 text-sm", );
filteredItems.some( const renderedExpanded = !collapsedGroups.has(
(item) => pageToggle === item.key, group.label,
) );
? "text-primary" return (
: "text-sidebar-foreground/80", <Collapsible
)} open={renderedExpanded}
> onOpenChange={() =>
<div>{t("menu." + group.label)}</div> toggleGroupCollapsed(group.label)
</SidebarGroupLabel> }
<SidebarMenuSub className="mx-2 border-0"> >
{filteredItems.map((item) => ( <SidebarGroupLabel
<SidebarMenuSubItem key={item.key}> asChild
<SidebarMenuSubButton className={cn(
className="h-auto w-full py-1.5" "ml-2 pl-0 text-sm",
isActive={pageToggle === item.key} hasActiveItem
onClick={() => { ? "text-primary"
if ( : "text-sidebar-foreground/80",
!isAdmin && )}
!ALLOWED_VIEWS_FOR_VIEWER.includes( >
item.key as SettingsType, <CollapsibleTrigger className="flex w-full items-center justify-between">
) <div>{t("menu." + group.label)}</div>
) { <LuChevronRight
setPageToggle("uiSettings"); className={cn(
} else { "size-4 shrink-0 transition-transform duration-200",
setPageToggle(item.key as SettingsType); renderedExpanded && "rotate-90",
}
}}
>
<div className="w-full cursor-pointer">
{renderMenuItemLabel(
item.key as SettingsType,
)} )}
</div> />
</SidebarMenuSubButton> </CollapsibleTrigger>
</SidebarMenuSubItem> </SidebarGroupLabel>
))} <CollapsibleContent>
</SidebarMenuSub> <SidebarMenuSub className="mx-2 border-0 md:mx-0">
</> {filteredItems.map((item) => (
<SidebarMenuSubItem key={item.key}>
<SidebarMenuSubButton
className="h-auto w-full py-1.5"
isActive={pageToggle === item.key}
onClick={() => {
if (
!isAdmin &&
!ALLOWED_VIEWS_FOR_VIEWER.includes(
item.key as SettingsType,
)
) {
setPageToggle("uiSettings");
} else {
setPageToggle(
item.key as SettingsType,
);
}
}}
>
<div className="w-full cursor-pointer">
{renderMenuItemLabel(
item.key as SettingsType,
)}
</div>
</SidebarMenuSubButton>
</SidebarMenuSubItem>
))}
</SidebarMenuSub>
</CollapsibleContent>
</Collapsible>
);
})()
)} )}
</SidebarGroup> </SidebarGroup>
); );