administrator/frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2026-06-21 03:41:55 +03:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

reset form only on open transition

Browse Source
This commit is contained in:
Josh Hawkins 2026-05-28 09:00:56 -05:00
parent 22bd7359f8
commit 05256b696c
1 changed files with 21 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
web/src/components/settings/CloneCameraDialog.tsx
View File

@ -1,4 +1,4 @@
import { useCallback, useEffect, useMemo, useState } from "react"; import { useCallback, useEffect, useMemo, useRef, useState } from "react";
import { useForm, useWatch } from "react-hook-form"; import { useForm, useWatch } from "react-hook-form";
import { zodResolver } from "@hookform/resolvers/zod"; import { zodResolver } from "@hookform/resolvers/zod";
import { z } from "zod"; import { z } from "zod";
@ -143,17 +143,6 @@ export default function CloneCameraDialog({
}, },
}); });
// Reset whenever the dialog opens.
useEffect(() => {
if (open) {
form.reset({
targetMode: "new",
newName: "",
existingTarget: otherCameras[0] ?? "",
});
}
}, [open, form, otherCameras]);
const targetMode = form.watch("targetMode"); const targetMode = form.watch("targetMode");
const existingTarget = form.watch("existingTarget"); const existingTarget = form.watch("existingTarget");
@ -172,12 +161,28 @@ export default function CloneCameraDialog({
const [selectedCategories, setSelectedCategories] = useState< const [selectedCategories, setSelectedCategories] = useState<
Set<CloneCategoryKey> Set<CloneCategoryKey>
>(() => getCategoryDefaults(true, true)); >(() => getCategoryDefaults(true));
// Reset defaults when target mode or target identity changes. // Reset form + selection only on the open transition
const wasOpenRef = useRef(false);
useEffect(() => { useEffect(() => {
setSelectedCategories(getCategoryDefaults(targetIsNew, resMatch)); if (open && !wasOpenRef.current) {
}, [targetIsNew, existingTarget, resMatch]); wasOpenRef.current = true;
form.reset({
targetMode: "new",
newName: "",
existingTarget: otherCameras[0] ?? "",
});
setSelectedCategories(getCategoryDefaults(true));
} else if (!open) {
wasOpenRef.current = false;
}
}, [open, form, otherCameras]);
// Reset selection to per-mode defaults when the user switches target mode.
useEffect(() => {
setSelectedCategories(getCategoryDefaults(targetIsNew));
}, [targetIsNew]);
const toggleCategory = useCallback((key: CloneCategoryKey) => { const toggleCategory = useCallback((key: CloneCategoryKey) => {
setSelectedCategories((prev) => { setSelectedCategories((prev) => {