From 0115265cb6a555305556df3f047e9363a2f5380e Mon Sep 17 00:00:00 2001 From: ryzendigo Date: Sat, 21 Mar 2026 17:21:48 +0800 Subject: [PATCH] fix: use dependencies=[] for auth deps, fix balance test --- frigate/api/recap.py | 4 ++-- frigate/test/test_recap.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/frigate/api/recap.py b/frigate/api/recap.py index 45715bc7a..10e8646df 100644 --- a/frigate/api/recap.py +++ b/frigate/api/recap.py @@ -24,6 +24,7 @@ router = APIRouter(tags=[Tags.recap]) description="Creates a video showing all detected objects from the given time range " "composited onto a clean background. Each detection appears at its real " "position with a timestamp label.", + dependencies=[Depends(require_role(["admin"]))], ) def generate_recap( request: Request, @@ -31,7 +32,6 @@ def generate_recap( start_time: float, end_time: float, label: Optional[str] = None, - _: str = Depends(require_role(["admin"])), ): config = request.app.frigate_config @@ -84,11 +84,11 @@ def generate_recap( @router.get( "/recap/{camera_name}", summary="List recap exports for a camera", + dependencies=[Depends(require_camera_access)], ) def get_recaps( request: Request, camera_name: str, - _: str = Depends(require_camera_access()), ): recaps = ( Export.select() diff --git a/frigate/test/test_recap.py b/frigate/test/test_recap.py index eb94d8d54..911335ca0 100644 --- a/frigate/test/test_recap.py +++ b/frigate/test/test_recap.py @@ -145,8 +145,8 @@ class TestBalanceGroups(unittest.TestCase): {"frames": [1] * 10, "time": 2}, {"frames": [1] * 10, "time": 3}, ] - groups = _balance_groups(events, 3) - # long events should end up in different groups + groups = _balance_groups(events, 2) + # with max 2 per group, the two long events must be in separate groups group_maxes = [max(len(e["frames"]) for e in g) for g in groups] self.assertIn(500, group_maxes) self.assertIn(400, group_maxes)